Review: Needs Fixing Dear Ravi, Can you please avoid commenting out code? If some code must go, then delete it. This makes the diff much clearer. Moreover, keeping code in comments is taking the risk that someone else uncomments it by accident, and therefore introduces a bug. So please delete methods _email_get and _email_set.
Another comment: please don't change the parameter name of method _generate_signature. There is no reason to change the API, only the implementation changes. Once this is done and reviewed by Amit, we should consider defining a migration. An upgrade of the base module should keep the existing values of user_email. The migration should do something like: first redefine user_email, then copy address_id.email to user_email for all users, then drop column address_id. Thanks, Raphael -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-usability-remove_address_id_email-rmu/+merge/64812 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-usability. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
