Review: Needs Fixing
I don't see any point for the code:
+ 'payment_term': address.partner_id.property_payment_term and
address.partner_id.property_payment_term.id or False
as we already have a method _get_payment_term,
also the code below is needed to be cleaned: (stock/stock.py)
payment_term_id = False
...
...
if inv_type in ('out_invoice', 'out_refund'):
account_id = partner.property_account_receivable.id
payment_term_id = self._get_payment_term(cr, uid, picking)
else:
...
if we really need payment_term_id just take proper values directly from the
well defined function for the first time,
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-798256-aag/+merge/64999
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-798256-aag.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
