Xavier (Open ERP) has proposed merging 
lp:~openerp-dev/openerp-web/trunk-fix-gantt-search_read-xmo into lp:openerp-web.

Requested reviews:
  Chirag Patel (OpenERP) (cpa-openerp)
  Nicolas Vanhoren (OpenERP) (niv-openerp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-fix-gantt-search_read-xmo/+merge/65477

Gantt currently fetches its data (for reloading) by calling 
/base/dataset/search_read directly.

It should be using DataSetSearch.read_slice instead, especially since it 
already has a dataset the call is simpler and it makes the precise values 
returned by /base/dataset/search_read easier to change for pagination fixes.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-fix-gantt-search_read-xmo/+merge/65477
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-fix-gantt-search_read-xmo.
=== modified file 'addons/base/static/src/js/list-editable.js'
--- addons/base/static/src/js/list-editable.js	2011-06-08 14:58:50 +0000
+++ addons/base/static/src/js/list-editable.js	2011-06-22 11:08:17 +0000
@@ -125,6 +125,15 @@
                     'class': $(row).attr('class'),
                     click: function (e) {e.stopPropagation();}
                 })
+                .delegate('button.oe-edit-row-save', 'click', function () {
+                    self.save_row();
+                })
+                .delegate('button.oe-edit-row-cancel', 'click', function () {
+                    self.cancel_edition();
+                })
+                .delegate('button', 'keyup', function (e) {
+                    e.stopImmediatePropagation();
+                })
                 .keyup(function (e) {
                     switch (e.which) {
                         case KEY_RETURN:
@@ -136,12 +145,6 @@
                         default:
                             return;
                     }
-                })
-                .delegate('button.oe-edit-row-save', 'click', function () {
-                    self.save_row();
-                })
-                .delegate('button.oe-edit-row-cancel', 'click', function () {
-                    self.cancel_edition();
                 });
             if (row) {
                 $new_row.replaceAll(row);

=== modified file 'addons/base_gantt/static/src/js/gantt.js'
--- addons/base_gantt/static/src/js/gantt.js	2011-05-20 06:16:50 +0000
+++ addons/base_gantt/static/src/js/gantt.js	2011-06-22 11:08:17 +0000
@@ -262,21 +262,13 @@
         throw "Unrecognized date/time format";
     },
 
-    reload_gantt: function(domain) {
+    reload_gantt: function() {
         var self = this;
-        var ajax = {
-                url: '/base/dataset/search_read',
-                async: false
-            };
-            this.rpc(ajax, {
-                model: this.dataset.model,
-                domain: self.dataset.domain,
-                context :self.dataset.context
-            }, function(response) {
-                ganttChartControl.clearAll();
-                jQuery("#GanttDiv").children().remove();
-                self.load_event(response);
-            });
+        this.dataset.read_slice(false, false, false, function(response) {
+            ganttChartControl.clearAll();
+            jQuery("#GanttDiv").children().remove();
+            self.load_event(response);
+        });
     },
 
     do_search: function (domains, contexts, groupbys) {
@@ -290,7 +282,7 @@
         }, function (results) {
             self.dataset.context = results.context;
             self.dataset.domain = results.domain;
-            return self.reload_gantt(self.dataset.domain);
+            self.reload_gantt();
         });
     }
 

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to