Review: Needs Fixing
Ujjvala,
Your merge proposal working fine functionally as i have tested but need to fix
few things in code:
- missing context on onchange_product_packings
- No need to create warning_msg variable, you can directly use it
- set default for flag=False on onchange_product_packings
- + warning = res.get('warning', {}) => fix this line as if there is warning
from product onchange it will be override
- remove unused argument pricelist from onchange_product_packing
- + packaging = False
+ result['product_packaging'] = False
should be packaging=result['product_packaging']=False
Thanks,
mra
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-795487-uco/+merge/65440
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-795487-uco.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
