Review: Needs Fixing
its working fine but the way the test is implemented is wrong,
we want this yml test in order to check if its working fine or not,
we don't need to do any extra code and checking in this, just to call proper
functions we need
e.g. for "I update the contract to "My Yesterday's Contract" at the date of
yesterday."
no need to check for temporal_mode, not to call shallow_copy manually
just find proper date and call write
yes, it needs some tricks as if we provide only temporal_date_from it will work
like a simple write,
do something as follow:
for "I update the contract to "My Yesterday's Contract" at the date of
yesterday."
- call write providing only new name
- find date
- call write again providing date
another thing, improve code too,
+ assert version_ids, _('Not Found 4 versions of the My Contract')
we have to check if the length is 4 or not, it will simply run even if we get
only 1 version,
improve the conditions properly
thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa-yml-ksa/+merge/65932
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
