Review: Needs Fixing
the fix is not working properly for all cases:
in _get_journal_id you have put the condition:
17 + if not vals:
18 + raise osv.except_osv(_('Warning !'), _('Either there are no moves
linked to the picking or Accounting Journals are misconfigured!'))
when we are going to invoice more than one picking to be invoiced at a time one
is without any move lines and another is with move lines , we will get values
for journal, so this warning is not that useful, (even, not useful as this
warning will come for the picking that are "NOT to be Invoiced")
The more weird thing is,
if we have 3 incoming shipments (to be invoiced) one is without any move lines
and others are with move lines, and we invoice them by selecting all in the
tree view, the generated invoices for all the incoming shipment are "Customer
Invoice" instead of "Supplier Invoice",
so improve the checking properly to make it working Correctly,
Thanks
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-689675-mma/+merge/65189
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-689675-mma.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
