Hi Naresh,
May I suggest some additional improvements:
- please include the module and name in the exceptions message, for diagnostics
purpose, e.g:
raise cPickle.UnpicklingError('Unsafe pickled class instance: %s.%s' %
(module,name))
- different kinds of exceptions may be passed over netrpc apparently, so until
we patch the server to wrap them all, we can allow them all like this (need to
add import 'exceptions' and 'types'):
EXCEPTION_CLASSES = [x for x in dir(exceptions) if
type(getattr(exceptions,x)) == types.TypeType]
SAFE_CLASSES = { 'exceptions' : EXCEPTION_CLASSES }
Thanks!
--
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-bug-671926-nch/+merge/66747
Your team OpenERP sa GTK client R&D is requested to review the proposed merge
of lp:~openerp-dev/openobject-client/trunk-bug-671926-nch into
lp:openobject-client.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
