Rucha (Open ERP) has proposed merging 
lp:~openerp-dev/openobject-server/trunk-configuration-rework-import_imp-rpa 
into lp:~openerp-dev/openobject-server/trunk-configuration-rework.

Requested reviews:
  qdp (OpenERP) (qdp)

For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-import_imp-rpa/+merge/66791

 for the dict returned by the button_xxx methods: defined a single dict D and 
return dict(D, name='xxx').

-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-configuration-rework-import_imp-rpa/+merge/66791
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/trunk-configuration-rework.
=== modified file 'openerp/addons/base/module/module.py'
--- openerp/addons/base/module/module.py	2011-06-30 13:18:18 +0000
+++ openerp/addons/base/module/module.py	2011-07-04 13:36:38 +0000
@@ -40,6 +40,16 @@
 
 from osv import fields, osv, orm
 
+
+ACTION_DICT = {
+            'view_type': 'form',
+            'view_mode': 'form',
+            'res_model': 'base.module.upgrade',
+            'target': 'new',
+            'type': 'ir.actions.act_window',
+            'nodestroy':True,
+        }
+
 class module_category(osv.osv):
     _name = "ir.module.category"
     _description = "Module Category"
@@ -286,15 +296,7 @@
 
     def button_install(self, cr, uid, ids, context=None):
         self.state_update(cr, uid, ids, 'to install', ['uninstalled'], context)
-        return {
-            'name': _('Install'),
-            'view_type': 'form',
-            'view_mode': 'form',
-            'res_model': 'base.module.upgrade',
-            'target': 'new',
-            'type': 'ir.actions.act_window',
-            'nodestroy':True,
-        }
+        return dict(ACTION_DICT, name=_('Install'))
         
 
     def button_install_cancel(self, cr, uid, ids, context=None):
@@ -315,15 +317,7 @@
             if res:
                 raise orm.except_orm(_('Error'), _('Some installed modules depend on the module you plan to Uninstall :\n %s') % '\n'.join(map(lambda x: '\t%s: %s' % (x[0], x[1]), res)))
         self.write(cr, uid, ids, {'state': 'to remove'})
-        return {
-            'name': _('Uninstall'),
-            'view_type': 'form',
-            'view_mode': 'form',
-            'res_model': 'base.module.upgrade',
-            'target': 'new',
-            'type': 'ir.actions.act_window',
-            'nodestroy':True,
-        }
+        return dict(ACTION_DICT, name=_('Uninstall'))
 
     def button_uninstall_cancel(self, cr, uid, ids, context=None):
         self.write(cr, uid, ids, {'state': 'installed'})
@@ -360,20 +354,12 @@
                     to_install.extend(ids2)
 
         self.button_install(cr, uid, to_install, context=context)
-        return {
-            'name': _('Upgrade'),
-            'view_type': 'form',
-            'view_mode': 'form',
-            'res_model': 'base.module.upgrade',
-            'target': 'new',
-            'type': 'ir.actions.act_window',
-            'nodestroy':True,
-        }
-#        return True
+        return dict(ACTION_DICT, name=_('Upgrade'))
 
     def button_upgrade_cancel(self, cr, uid, ids, context=None):
         self.write(cr, uid, ids, {'state': 'installed'})
         return True
+
     def button_update_translations(self, cr, uid, ids, context=None):
         self.update_translations(cr, uid, ids)
         return True

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to