Review: Needs Fixing
1) this wizard is not working for physical inventory, its giving traceback
2) some suggestions for names of method:
lot_check_qty => check_lot_qty
get_split_line => get_split_lines
back_split => go_back/back
3) word "order" doesn't suit in the warning message, this wizard is generic and
used in inventory too
4) def lot_check_qty:
why there is a search and read on ir.model.data to get view reference, we
already have methods in ir.model.data to get id
5) def get_split_line:
I think we can simplify this method and remove unused arguments
6) if quantity_rest == 0 or quantity_rest < 0:
can't it be simply if quantity_rest <= 0 ?? ;-)
7) default_get of stock.move.split.message
uom = self.pool.get('product.uom').browse(cr, uid, move.product_uom.id,
context=context).name
will be move.product_uom.name
again check this variable is no longer used in that function
8) res.update({'line_ids': (context.get('line')) or False})
will be context.get('line', [])
also its better to use 'lines' instead of 'line'
9) if possible I would like to reduce lots of code in def split and
lot_check_qty, please check if there is a chance to make both common,
can't we use split_lot instead of new method lot_check_qty?
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-776245-ron/+merge/61725
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-776245-ron.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
