Review: Needs Fixing
Bharat,

Your Merge proposal does not solve the problem fully,

line 22: if journal.type_control_ids and not (journal.account_control_ids): => 
if not (journal.account_control_ids):

with your patch it seems if there are type control ids then only it will go to 
check account control ids which is totally incorrect.

And display warnings with given conditions seems not well too. line number 
41,43.

you have to re built your code again too proper fix.

Thanks,
Mustufa
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-791132-bde/+merge/63653
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-bug-791132-bde.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to