Rucha (Open ERP) has proposed merging
lp:~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa-usability-imp-rpa
into
lp:~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa.
Requested reviews:
qdp (OpenERP) (qdp)
For more details, see:
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa-usability-imp-rpa/+merge/67661
Improvement in usability:
• Added proper tooltip for fields of temporal
• Put proper labels of fields,
• Improvements in views and menu structure, improved indentation,
• Added new field and button in order to test o2m field properly
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa-usability-imp-rpa/+merge/67661
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-temporal-db-intermediate-branch-rpa-ksa.
=== modified file 'base_temporal/base_temporal.py'
--- base_temporal/base_temporal.py 2011-07-11 14:40:05 +0000
+++ base_temporal/base_temporal.py 2011-07-12 07:18:19 +0000
@@ -82,12 +82,14 @@
def __init__(self, pool, cr):
self._columns.update({
- 'temporal_date_from': fields.datetime('Temporal From Date', select=True),
- 'temporal_date_to': fields.function(self.set_date, method=True, select=True, string='Temporal To Date', type='datetime',
- store = {
- self._name: (self.get_previous_id_in_timeline , ['temporal_date_from'], 10),
- }),
- 'temporal_parent_id': fields.integer('Temporal Parent ID', select=True, readonly=True),
+ 'temporal_date_from': fields.datetime('Validity From', select=True, help="Date from which the values of the record is valid."),
+ 'temporal_date_to': fields.function(self.set_date, method=True,
+ help="Date until which the values of the record is valid. No value in this field indicates that validity of this record is infinity.",
+ select=True, string='Validity To', type='datetime',
+ store = {
+ self._name: (self.get_previous_id_in_timeline , ['temporal_date_from'], 10),
+ }),
+ 'temporal_parent_id': fields.integer('Temporal Parent ID', select=True, readonly=True, help="ID reference of the main record."),
})
return super(orm_temporal, self).__init__(pool, cr)
=== modified file 'base_temporal/base_temporal_test.py'
--- base_temporal/base_temporal_test.py 2011-06-29 15:35:01 +0000
+++ base_temporal/base_temporal_test.py 2011-07-12 07:18:19 +0000
@@ -26,8 +26,8 @@
_description = "Base Temporal"
_columns = {
- 'name': fields.char('Temporal Name', size=64),
- 'line_ids': fields.one2many('base.temporal.test.line', 'test_id', 'Line IdS'),
+ 'name': fields.char('Name', size=64),
+ 'line_ids': fields.one2many('base.temporal.test.line', 'test_id', 'Lines'),
}
#in order to test if the temporal date is transactional
@@ -40,14 +40,24 @@
# print self.read(cr, uid, ids, ['temporal_date_from'])[0]['temporal_date_from']
# return res
+
+ def button_test(self, cr, uid, ids, context=None):
+# This function is to test Creation/Updation of o2m object
+ lineobj = self.pool.get('base.temporal.test.line')
+ for test in self.browse(cr, uid, ids, context=context):
+ for line in test.line_ids:
+ lineobj.write(cr, uid, line.id, {'code': 'ABC'}, context=context)
+ return True
+
base_temporal_test()
class base_temporal_test_line(osv.osv_temporal):
_name = "base.temporal.test.line"
_description = "Base Temporal Line"
_columns = {
- 'name': fields.char('Temporal Name', size=64),
- 'test_id': fields.many2one('base.temporal.test','Test ID'),
+ 'name': fields.char('Name', size=64),
+ 'code': fields.char('Code', size=3),
+ 'test_id': fields.many2one('base.temporal.test','Test ID', ondelete='cascade'),
}
base_temporal_test_line()
=== modified file 'base_temporal/base_temporal_test_view.xml'
--- base_temporal/base_temporal_test_view.xml 2011-06-21 06:58:52 +0000
+++ base_temporal/base_temporal_test_view.xml 2011-07-12 07:18:19 +0000
@@ -1,8 +1,10 @@
<?xml version="1.0" encoding="utf-8"?>
<openerp>
- <data>
+ <data>
+ <menuitem id="menu_temporal_root" name="Temporal Test"
+ parent="base.menu_base_partner" sequence="50"/>
- <record model="ir.ui.view" id="view_base_temporal_test_form">
+ <record model="ir.ui.view" id="view_base_temporal_test_form">
<field name="name">base.temporal.test.form</field>
<field name="model">base.temporal.test</field>
<field name="type">form</field>
@@ -15,32 +17,44 @@
<field colspan="4" name="line_ids" nolabel="1" mode="tree,form">
<tree string="Base Temporal Test Lines">
<field name="name"/>
+ <field name="code"/>
<field name="test_id"/>
+ <field name="temporal_date_from"/>
+ <field name="temporal_date_to"/>
+ <field name="temporal_parent_id"/>
</tree>
<form string="Base Temporal Test Lines">
<field name="name"/>
- <field name="test_id"/>
+ <field name="code"/>
+ <field name="temporal_date_from"/>
+ <field name="temporal_date_to"/>
+ <field name="temporal_parent_id"/>
</form>
</field>
+ <group colspan="4" col="3">
+ <label string="" colspan="2"/>
+ <button string="Update" name="button_test" icon="gtk-apply" type="object"
+ help="This button is to test Creation/Updation of o2m object at the same time."/>
+ </group>
</form>
</field>
- </record>
-
- <record model="ir.ui.view" id="view_base_temporal_test_tree">
- <field name="name">base.temporal.test.tree</field>
- <field name="model">base.temporal.test</field>
- <field name="type">tree</field>
- <field name="arch" type="xml">
- <tree string="Base Temporal Test">
- <field name="name"/>
- <field name="temporal_date_from"/>
- <field name="temporal_date_to"/>
- <field name="temporal_parent_id"/>
- </tree>
- </field>
- </record>
-
- <record model="ir.actions.act_window" id="action_base_temporal_test_tree">
+ </record>
+
+ <record model="ir.ui.view" id="view_base_temporal_test_tree">
+ <field name="name">base.temporal.test.tree</field>
+ <field name="model">base.temporal.test</field>
+ <field name="type">tree</field>
+ <field name="arch" type="xml">
+ <tree string="Base Temporal Test">
+ <field name="name"/>
+ <field name="temporal_date_from"/>
+ <field name="temporal_date_to"/>
+ <field name="temporal_parent_id"/>
+ </tree>
+ </field>
+ </record>
+
+ <record model="ir.actions.act_window" id="action_base_temporal_test_tree">
<field name="name">Base Temporal Test</field>
<field name="res_model">base.temporal.test</field>
<field name="type">ir.actions.act_window</field>
@@ -50,11 +64,11 @@
<field name="search_view_id" ref="view_base_temporal_test_tree"/>
</record>
- <menuitem action="action_base_temporal_test_tree"
- id="menu_partner_temporal_tree"
- parent="base.menu_base_partner" sequence="50"/>
+ <menuitem action="action_base_temporal_test_tree"
+ id="menu_partner_temporal_tree"
+ parent="menu_temporal_root" sequence="50"/>
- <record model="ir.actions.act_window" id="action_base_temporal_test_1">
+ <record model="ir.actions.act_window" id="action_base_temporal_test_1">
<field name="name">Base Temporal Test All</field>
<field name="res_model">base.temporal.test</field>
<field name="type">ir.actions.act_window</field>
@@ -64,9 +78,10 @@
<field name="search_view_id" ref="view_base_temporal_test_tree"/>
</record>
- <menuitem action="action_base_temporal_test_1"
- id="menu_partner_temporal_tree1"
- parent="base.menu_base_partner" sequence="50"/>
+ <menuitem action="action_base_temporal_test_1"
+ id="menu_partner_temporal_tree1"
+ parent="menu_temporal_root" sequence="50"/>
+
</data>
</openerp>
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp