Review: Needs Fixing
-if sale.state not in ('draft', 'cancel'): => state==done
- do not use "ids" gives proper variable name line_ids : ids = [line.id for
line in sale.order_line]
+ invoice_ids = [invoice_line.invoice_id for invoice_line in
invoice_line_obj.browse(cursor, user, result, context=context)]
+ invoice_id = [invoice.id for invoice in invoice_ids if invoice_ids]
=> you can merge above two lines
- if invoice_id[0]: => i am not sure about this
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-799083-mtr/+merge/67151
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-799083-mtr.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
