Review: Needs Fixing
1. I am not sure common.message is the right error to raise here.
- Are you sure it's not just for RPC communications?
- The issue seems slightly more problematic than a mere message, maybe
something stronger (at least a warning) would be a better idea would it not?
2. the common.* functions are shortcuts to raising errors: they raise the
errors themselves and do not return anything, there is no need to call `raise`
you just have to call the helper function.
if you want to explicitly raise something, raise one of the exception types
in openobject.errors
--
https://code.launchpad.net/~openerp-dev/openobject-client-web/6.0-bug-16159-msh/+merge/67813
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-client-web/6.0-bug-16159-msh.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
