Review: Approve
Amit,

Its a good catch.

I prefer a better line on warning.
Reasons;
1. A functional Person doesn't always understand the technical term 'Payslip 
line'.
2. You didn't specify where one can set the Designation for an employee.

I prefer this,
'Payslip cannot be approved due to one of the following reasons:
1. The Structure line + line.name + has not been linked with an analytic 
account.
2. Payslip for slip.employee_id.name is missing the configuration of 
Designation from 'Accounting Details'
'

Priyesh, I let you decide the best option to go with and you may proceed to 
merge it once you yourself approve it. 

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-16091-ado/+merge/68535
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-16091-ado.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to