Review: Needs Fixing good efforts, but the way methods are introduced and used makes the code messy and not understandable properly,
1. there is no return in execute and copy_translation 2. copy_translation is not relevant, use "copy_translations" instead 3. use of flag(error and done) and break should be written again in order to decrease complexity 4. Please add some "good" docstring in the methods 5. Make sure of the indentation level, line 84 of the diff and the xml 6. line 80-81 can be used well together with line 83 7. Also check some variable defined is not used thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-l10n-control-dev-load-translation-acc-template-ron/+merge/69029 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-l10n-control-dev. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
