Review: Needs Fixing Hardik, Aline has carefully tested your branch. Here is our joint feedback.
Stock moves as such are cancelled correctly, so that part is fine. But they generate inconsistent accounting lines when there is a value in "Stock Input Account" or "Stock Output Account" in the associated product or its product category. Once you have an account there, the stock move will generate accounting operations in order to track the current stock value. Maybe you should try such an example by yourself, so you can test your changes. We cannot "revert" those accounting operations at the moment. Instead, in that case we will prevent the cancellation of the picking. More technically, I suggest you do the following: - check the condition(s) that trigger accounting operations related to stock moves; - try to determine whether we can track the existence of accounting operations related to a particular stock move; - if a stock move has created accounting operations, it should not be cancelled (maybe reintroduce a condition allow_cancel in the workflow); - reflect that on pickings. Thanks, Raphael -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-usability-Be_able_to_cancel_some_documents-han/+merge/68361 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-usability. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
