Review: Needs Fixing First look in the diff provided by you i can filter some fixes on it,
1. === modified file 'account/account.py' => What is the change for ? 2. def value_period_id and def value_journal_id => it returns True always so what is the need for if condition (I am not sure about logic you have made on it as i have not tested it functionally) 3. def _get_period_id and def _get_journal_id => for inside for loop with just browse purpose : what you have done you have just loop the ids and second loop for browsing the same ids. 4. use proper variable names 5. Make sure removing select=1 and 2 does not effect anywhere in column defination. Last but not least i can not install the account module when i apply your patch so i could not reviewed. Thanks, Mustafa -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-777640-bde/+merge/69248 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-777640-bde. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
