Review: Needs Fixing
Manipulating dom elements in the dialog should not be done directly with jquery
object but using the this.$element of the dialog. So basically, all jquery
usage done this way :
$('#add_field').click(function(){ ...
should be done this way instead :
this.$element.find('#add_field').click(function() {
This avoids matching unwanted elements. (eg: two webclients on the same page)
Also, in css, the convention is to prepend all css declarations with .openerp,
it is also better to prefix classes and ids with oe_[module] so a css
declaration like this :
.readonlyfield{
background-color: DarkGray;
}
.row:hover{
background-color: #F3F3F3;
}
.fields-selector-export {
width: 100%;
height: 400px;
}
is better done this way :
.openerp .oe_export_readonlyfield {
background-color: DarkGray; <-- if possible, try to avoid named colors
}
.openerp .oe_export_row: hover {
background-color: #F3F3F3;
}
.openerp .oe_export_fields_selector {
width: 100%;
height: 400px;
}
There's a new Sidebar api that should be used for import/export. But I will do
the implementation myself.
--
https://code.launchpad.net/~openerp-dev/openerp-web/export-import-ysa/+merge/68839
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/export-import-ysa.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
