Review: Needs Fixing
Hello Valencia,

The fix seems to work. But I feel that line no 14 is of no use.

What if I haven't selected a register? It would not calculate the contribution 
which is wrong.

So IMHO We don't need this line  if contrib_line.register_id:

Kindly correct it.

Thanks.

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-6348-vro/+merge/66067
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-6348-vro.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to