Review: Needs Fixing i only made a fast review and didn't even tried to launch the tests :D, but i wanted to see what has been done. I realized that it seems almost good, hence i'd like few small things to be changed.
line 215 of the diff: + I check that my voucher is valid actually it should be: i check that the move of my voucher is valid. What you need to check isn't the voucher state but the state of the move lines of the voucher's move. line 223 of the diff : use elif statements and raise an error if a line is not matching any of your statements more changed may be asked later, but it seems to be a cool work so far ;-) Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-account-voucher-rework-mtr/+merge/70116 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-account-voucher-rework-mtr. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
