Review: Approve Hello Jay and Olivier, I definitely agree with you both. Ravi has updated the code for the same.
@Ravi There is still a vulnerability in the code. Logically it's not possible but technically it is. What if a company has no warehouse? It may crash the system. So I prefer to keep a condition at line 16. If and only if warehouse exists for a company then the rest of the code should be executed. Thanks for your valuable contributions. -- https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-bug-725571-rgo/+merge/68682 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/6.0-bug-725571-rgo. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
