Review: Needs Fixing demo is not good, please don't refer to an id of existing templates as its conflicting
in generate_fiscal_position, param taxes_ids is inappropriate, please put proper name and use proper value, i found only taxes_ids['tax_template_ref'] is used, you can improve values passed, condition of line 25 is not needed, it will work properly without it. you can also remove some intermediate variable. thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-l10n-control-dev-split-fiscal-position-func-from-execute-func-ron/+merge/71002 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-l10n-control-dev. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
