Review: Needs Fixing few improvements to do: use proper methods to get id from ir.model.data instead of search and browse
some of the code is same to create sale/purchase journals: 41 + if chart_template_id.property_account_receivable: 42 + vals_journal['default_credit_account_id'] = acc_template_ref[chart_template_id.property_account_income_categ.id] 43 + vals_journal['default_debit_account_id'] = acc_template_ref[chart_template_id.property_account_income_categ.id] 44 + obj_journal.create(cr,uid,vals_journal) 79 + if chart_template_id.property_account_receivable: 80 + vals_journal['default_credit_account_id'] = acc_template_ref[chart_template_id.property_account_income_categ.id] 81 + vals_journal['default_debit_account_id'] = acc_template_ref[chart_template_id.property_account_income_categ.id] 82 + obj_journal.create(cr, uid, vals_journal, context=context) you can simplify it thanks -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-l10n-control-dev-split-journals-func-from-execute-func-ron/+merge/71664 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-l10n-control-dev. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp

