Review: Needs Fixing The unbind looks fine, but have you tested the other part?
In the add event: 1. you're using sc.lenght, that property does not exist, it would be sc.length 2. why are you splicing from the last element in order to add just a record? Why not just use push? 3. what's the point of pushing nothing (via apply too) at line 596? 4. the $shortcut variable is now unused. It should be removed. 5. incidentally, its code shoud be reindented since the indentation is now incorrect In the remove event: 1. you've created sc1 is an implicit global since it's not declared 2. please rename this variable to something clearer as to its purpose as well, the current name is anything but -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-shortcut_fix/+merge/72161 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-shortcut_fix. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
