Review: Needs Fixing
* Broke db-password-change code in
vja@vja-desktop-20110819131007-0o2pxuvrvh9q5cc3 by changing indentation (it's
now impossible for the "Password not changed" error to appear, nothing happens
if the password change failed for any reason other than authentication)
* The web client does not work correctly once the password has been changed: if
the user does not log out and log back in, any tentative to work with the
client after having changed the password results in a "OpenERP Server Error"
which only displays a small traceback and the message "Server". Please
investigate and fix.
* Using object literals to create the action descriptor (chrome.js:633) would
be a bit more readable (and less repetitive)
* You still have leftover trailing commas (chrome.js:{663,664,678,696})
* An unnecessary semicolon at chrome.js:692
* And a leftover debugging log at chrome.js:685
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-preferences-vja/+merge/72534
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-preferences-vja.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
