Review: Needs Fixing
Bharat,

When you propose patch for some fixes, you should first check it with new 
database.
Here i can not install google_map module (due to sequence of loading of xml 
files!!)

I suggest few improvements/fixes too:
1. _launch_wizard => Do not change method name in your memory class keep old 
name
2. <field name="view_mode">tree,form,calendar,graph</field> => why cal and 
graph ?
3. + url=''
   + url="http://maps.google.com/maps?oi=map&q="; => We should merge these two 
lines.

Hope you will keep this suggestion in your mind for future fixes.

Thanks,
Mustufa
-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-google_map_wizard-bde/+merge/73215
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-google_map_wizard-bde.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to