Review: Needs Fixing
Hello Meera,

Thanks for efforts you have made.

But there are some correction which should be done to make yaml more strong to 
test flow of sale.

* 'sale/test/advance_invoice.yml'
  ** Wizard is to make advance payment for sale order. In the current yaml it 
creates invoice for advance payment + its reconciliation. So here no need to 
cancel the invoice and so on which will be covered by sale_male_invoice.yaml.

* 'sale/test/invoice_on_ordered_qty.yml'
  ** To check configuration wizard we should have separate yaml
  ** Improve the strings

* 'sale/test/manual_order_policy.yml'
  ** I verify that it opens Customer Invoices form view. => improve the 
checking of this state.
* 'sale/test/picking_order_policy.yml'
  ** If you are doing onchange_product_id => you can use that values for 
creating sale order lines
* 'sale/test/so_make_invoice.yml'
  ** do not use voucher for payment as sale is not depend on voucher module

Thanks,
Mustufa

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-sale_coverage-mtr/+merge/73351
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/trunk-sale_coverage-mtr.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to