Review: Needs Fixing Right idea, wrong execution:
* Instead of adding a parameter (which has nothing to do here) in ViewManager's render(), viewmanager should render this.template and the template name should be moved as a class attribute (as for widgets) * This way you can set a different template name (e.g. ViewManagerAction) for the ViewManagerAction * And that new template will inherit from the ViewManager template (instead of extending it in place, via t-extend + t-name) and add a link at the right place * Also, why is your selector rooting on semi-arbitrary HTML elements, since the parent element to the link already has a class why not just select it directly, via its classname? -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-842545-vda/+merge/74413 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-842545-vda. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
