Review: Needs Fixing

The idea seems good.

Instead of removing the function when the field is not a function field or not 
stored, we can in fact always remove it. This means the loop (a few lines below 
the changed code) to test if the current function will be appended or not can 
be removed.

The for-loop with calls to list.remove() is not safe (as it changes the 
iterated list). You can use instead a list comprehension ar a call to filter().
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-789576-nco/+merge/65303
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/trunk-bug-789576-nco.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to