Review: Disapprove
Hello,
The error about the column not existing comes from the case-sensitivity of the
column names in PostgreSQL: when column names are quoted with double-quotes (")
in a query, then the names are case-sensitive. If they are not quoted, then
they are *not* case-sensitive.
Both strategies are acceptable, but the same strategy must be used in all
queries, otherwise such problems occur.
Currently in most of the framework we quote column names, so we are
case-sensitive and we support spaces and upper case characters in the column
names.
As it turns out, there are a few cases where we don't do it, and this causes
the SQL error you mention.
So in order to be consistent, I think a better solution to the issue of
mixed-case names is to correct the few places were we forget the quotes. This
will not break anything (because many many queries use the quotes, including
those that create the columns), and will automatically fix your issue with
mixed-case custom columns.
I have committed a fix in the server that tries to fix all the places I found
where we had forgotten the quotes in the ORM code:
revision 3619 revid: [email protected]
After this patch I can create custom columns with mixed-case names and use them
in views without problem.
Please test and let me know if that works for you. Any remaining issue could be
fixed in the same manner.
Thanks!
--
https://code.launchpad.net/~openerp-dev/openobject-server/6.0-opw-field_name_validation-vro/+merge/72857
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-server/6.0-opw-field_name_validation-vro.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
