Review: Needs Fixing Thanks for the tests, this is really nice to have some.
I think the patch can be simpler: replace (at line 238 in my code, line 55 in the current merge prop.) right1 = table.search(cr, uid, [(fargs[0],'in', right)], context=context) by right1 = table.search(cr, uid, [(fargs[0],'in', right)], context=dict(context, active_test=False)) (The current test for the presence of active is not correct, as it tests its presence among the *previous* leaves, not among all leaves. And in fact that test is already done in _where_calc, which ensures but in some specific cases, that active is always present in the expression). -- https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-711919-ysa/+merge/63356 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/trunk-bug-711919-ysa. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
