Review: Needs Fixing

* I don't think there's any need to go through jQuery for this, you should just 
be able to set and unset the `disabled` property on `e.target` e.g. 
`e.target.disabled = true;` and `e.target.disabled = false;`. If you absolutely 
want to use jQuery, I'd suggest $.fn.prop [0] instead of $.fn.attr

* Fix indentation to stop using tabs, you inserted a tab before the removeAttr 
call. bzr can tell you about these by using `bzr cdiff --check-style` when 
reviewing your diffs before committing.

[0] http://api.jquery.com/prop/#prop2
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/6.1bug-817396-vda/+merge/74215
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/6.1bug-817396-vda.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to