Review: Disapprove

Calling self.reload_content means the whole list is going to be removed an 
reinserted, not just that the pager is going to be updated.

This has the following issues:

* If the list is long, the user will lose his position
* State unsaved (e.g. a line being edited) will be lost
* The list will flicker (all records will disappear and reappear)

Not to mention it is logically nonsensical to do it that way: `reload_content` 
empties the whole list and reloads it fully, so there is no need to recompute 
the aggregate results or to remove records one by one from the internal records 
collection.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-849020-vja/+merge/76332
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-849020-vja.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to