Review: Approve > Why wasn't it used ? This branch proposes to use Widget's philosophy.
That API changed quite a bit, and the most recent "shape" is quite recent (a few weeks?), and there has been no push to convert all of the client to it so far, especially since it's backwards-compatible (mostly). > I setup a "ListViewClass" attribute because otherwise I should do as you > hinted: replace "openerp.web_mobile.ListView". I cannot afford in the current > situation to break the web_mobile which code I must watch regularly, test, > tweak, and learn openerp. I must update daily the branch, and it's much more > convenient (and cleaner) to build an add-on that does not break "web_mobile" > add-on. I think I see what you mean, but I don't think it's very effective or useful: you're already overriding the list view for these classes, so if there are breaking changes there anything you've overridden (which is probably most of the mobile client) would break either way, would it not? So the only "breakages" you'd avoid would be on ListView-using classes on which these parameters were not added. Not sure it's worth the price of adding them, I think you should just go and extend/replace the mobile listview, that's pretty much the prescribed way of doing things. > sub-templating: I won't be using the same menu, but want to be able to use > the form template, or the list template in a different context (my Header and > Footer bars are different…). OK, does not sound good, i think you should go ahead and propose that improvement. -- https://code.launchpad.net/~vaab/openerp-web/mobile-client-use-widget-render/+merge/76606 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/mobile-client. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
