Review: Needs Fixing

ir.model.access.check() is not meant to be called in RPC, but it's better to 
fix it indeed, as it is technically RPC-exposed.

For the fix, wouldn't it be better to put `or False` on the return line 
instead, to catch future changes/mistakes.

As for a global solution, as you know XML-RPC support for `null` is not 
properly standardized so we shouldn't waste too much time with this. 
Introspecting returned data structure to catch None values seems like overkill. 
It's not very important, we'll gradually move over to JSON-RPC instead, which 
supports `null`, and in the mean time, developers should just be aware of it 
and be careful.
-- 
https://code.launchpad.net/~openerp-dev/openobject-server/6.0-opw-17601-rgo/+merge/76341
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-server/6.0-opw-17601-rgo.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to