Review: Needs Fixing

Hello Ravi,

* you have initialized the columns as 1 but as per the spec the @style 
attribute is mandatory no default value this is what the spec says:
@style is the dashboard's layout styles (columns split). It is mandatory (no 
default value) 
The number of <columns> in the <board> tag matches the @style layout spec, a 
mismatch is an undefined behavior (the client should always expect them to 
match)

* what does this statement mean? 
53      + self.column =+ self.column + 1

and lastly I did not get why you tried to adjust the "Action's" width rather 
then the <columns> according to the @styles attribute. It should be rather like 
this:for eg:style=1-2 
which means that the whole board is divided into 2 halves from which the second 
half is the twice of the first half i.e if you assume the width as 100 then the 
ratio stands to 33:66 (approx). 
now each columns can have any number of action's.


Thanks,
-- 
https://code.launchpad.net/~openerp-dev/openobject-client/trunk-new_dashboard_api-rga/+merge/74096
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-client/trunk-new_dashboard_api-rga.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to