Review: Disapprove
1. Fix is incomplete, if provide active_id, should provide active_ids and
active_model as well
2. Fix is not even correct: if you check why action breaks it's because it has
<field name="context">{'record_id' : active_id}</field>
Now if you check flow of this action and try to find where `record_id` is
used, it's not. So the issue is not that we don't have an active_id in context
of menu, it's that this action was copy/pasted from somewhere else and author
did not think. Correct fix would be to fix action, not to add random values.
Also, don't use dict.update just to set a single value on a dict. especially
not dict.update *with a literal dict*, it's significantly less efficient and
not even remotely as readable. Had it been correct, this line should have been
written:
req.session.context['active_id'] = menu_id
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-855343-jap/+merge/76957
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-bug-855343-jap.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
