Review: Needs Fixing There is no else case in the two last nested 'if' statements. - Can 'results' be empty? What should we return in that case? - What should the method do if not results[0][1] == 'pdf' ?
Otherwise it looks okay. -- https://code.launchpad.net/~openerp-dev/openobject-server/6.0-opw-17683-rgo/+merge/77108 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-server/6.0-opw-17683-rgo. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
