Hello vidhin,

Its working fine, but need some fixings.

1. Change the variable name. Variable names should be meaningful. change name1, 
one_object, side etc..
2. Remove trailing whitespace.
3. If we use variables list_shift, last_tr, next_tr in both the cases side-down,
 side-up then its better to initialize at the top. is it? 
4. Fix the indentation for loops
5. Use spaces after comma separated values

Thanks.
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-vieweditor-vme/+merge/77107
Your team OpenERP R&D Team is requested to review the proposed merge of 
lp:~openerp-dev/openerp-web/trunk-vieweditor-vme into 
lp:~openerp-dev/openerp-web/trunk-vieweditor-sma.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to