Review: Needs Fixing 1. Far's I can tell, you already know if anything was selected through the result.ids and result.records arrays, why create a different variable with little to no point instead of just testing on `result.ids.length`?
2. Testing an array's length for positivity is redundant (do you really think there could be negative lengths?) Just use it as a boolean 3. alternatively, if `.each()` can be chained (and I see no reason why it could not), you could just get its result, you'd get a jQuery collection of trs without the need for breaking the selection chain in two. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-856376-kbh/+merge/77681 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-856376-kbh. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
