Valentin Lab has proposed merging 
lp:~vaab/openerp-web/mobile-client-imp-fix-endless-refresh into 
lp:~openerp-dev/openerp-web/mobile-client.

Requested reviews:
  OpenERP R&D Team (openerp-dev)

For more details, see:
https://code.launchpad.net/~vaab/openerp-web/mobile-client-imp-fix-endless-refresh/+merge/77891

WTF ? How can this has made it to the repository ?

This code is evidently flawed. Needless to say that did trigger an endless 
refresh on my browser... just because my domain name is bigger than "127.0.0.1" 
length.

What may be needed is to detect '#' in the document.url... But I'm not quite 
sure what was the goal of such addition.
-- 
https://code.launchpad.net/~vaab/openerp-web/mobile-client-imp-fix-endless-refresh/+merge/77891
Your team OpenERP R&D Team is requested to review the proposed merge of 
lp:~vaab/openerp-web/mobile-client-imp-fix-endless-refresh into 
lp:~openerp-dev/openerp-web/mobile-client.
=== modified file 'addons/web_mobile/static/src/js/chrome_mobile.js'
--- addons/web_mobile/static/src/js/chrome_mobile.js	2011-09-29 09:48:06 +0000
+++ addons/web_mobile/static/src/js/chrome_mobile.js	2011-10-03 10:24:46 +0000
@@ -17,9 +17,6 @@
 
     init: function(element_id) {
         this._super(null, element_id);
-        if(document.URL.length>59){
-            window.location.replace('/mobile');
-        }
         openerp.web.qweb.add_template("xml/web_mobile.xml");
         var params = {};
         this.$element.html(this.render());

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to