Review: Needs Fixing

Sorry, but I disagree with your solution.

IMO, this is a workaround for a bug in method account_move_line.create().  The 
method uses 'total' as the untaxed amount, while some taxes may be included.  
On line 1314 of account_move_line.py, the dictionary returned by 
tax_obj.compute_all contains both taxed and untaxed amounts.  We should 
retrieve the untaxed amount from there, shouldn't we?

I suggest the following: replace line 1314 of account_move_line.py by

            tax_result = tax_obj.compute_all(cr, uid, [tax_id], total, 1.00)
            total = tax_result['total']              # untaxed amount
            for tax in tax_result['taxes']:

If that code works (please run all the tests you can!), then account_voucher 
would be correct without any modification.  What do you think?

Raphael

-- 
https://code.launchpad.net/~openerp-dev/openobject-addons/6.0-opw-17387-rha/+merge/76338
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openobject-addons/6.0-opw-17387-rha.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to