Review: Disapprove While the spirit of the fix looks good, the letter of the fix definitely is not: I don't think the sidebar has any business going deep into a sibling.
For this, I would recommend adding a method on View for a protocol of the sidebar getting context data from the view (like `View.sidebar_context()`), with default implementation doing nothing (just returning empty dict) and form view overriding this method to return its content. Also that method will probably need to be asynchronous (return a promise), because if for instance form is not saved form needs to save itself or there will be wrong data returned. -- https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-871714-vda/+merge/78913 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openerp-web/trunk-bug-871714-vda. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
