Review: Needs Fixing
You should keep the concept of code AND section name in add_section() method.
Currently, you use the section name in order to generate the section code
(using _.underscored ), but this will fail once we translate the section name
because you could get any character in the code and thus having broken element
id and classnames in the dom.
add_items() should also use a section code as identifier.
While you're at it, could you add the translations for sidebar default sections
with _t() :
add_default_sections: function() {
this.add_items('customize', _t('Customize'), [
{
label: _t("Manage Views"),
callback: this.call_default_on_sidebar,
title: _t("Manage views of the current object")
}, ...
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-sidebar-chs/+merge/78830
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-sidebar-chs.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
