Review: Needs Fixing
hello Divyesh,
Looking at the diff at line #48 and at line # 58 I don't understand the purpose
you are searching for *trans_id* if you don't find them you are doing some
stuff then at line #58 you are searching for the new *trans_id*.. do you think
this will work ?
secondly:did you test this before sending a merge proposal? because it breaks
when you perform copy operation with the traceback:
Traceback (most recent call last):
File "/home/nch/workspace/OpenERP2011/Trunk/server/openerp/osv/osv.py", line
120, in wrapper
return f(self, dbname, *args, **kwargs)
File "/home/nch/workspace/OpenERP2011/Trunk/server/openerp/osv/osv.py", line
172, in execute
res = self.execute_cr(cr, uid, obj, method, *args, **kw)
File "/home/nch/workspace/OpenERP2011/Trunk/server/openerp/osv/osv.py", line
163, in execute_cr
return getattr(object, method)(cr, uid, *args, **kw)
File
"/home/nch/workspace/OpenERP2011/Trunk/openobject-addons/mrp/product.py", line
99, in copy
return super(product_product, self).copy(cr, uid, id, default,
context=context)
File
"/home/nch/workspace/OpenERP2011/Trunk/openobject-addons/product/product.py",
line 639, in copy
context=context)
File "/home/nch/workspace/OpenERP2011/Trunk/server/openerp/osv/orm.py", line
4630, in copy
self.copy_translations(cr, uid, id, new_id, context)
File "/home/nch/workspace/OpenERP2011/Trunk/server/openerp/osv/orm.py", line
4583, in copy_translations
trans_id = trans_obj.search(cr, uid, [('src', '=',
obj_get_name_new[obj_field])])
TypeError: 'bool' object is not subscriptable
please test properly !
Thanks,
--
https://code.launchpad.net/~openerp-dev/openobject-server/trunk-bug-799655-mdi/+merge/78547
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-server/trunk-bug-799655-mdi.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
