Fabien Meghazi (OpenERP) has proposed merging 
lp:~openerp-dev/openerp-web/trunk-bug-878103-fme into lp:openerp-web.

Requested reviews:
  Xavier (Open ERP) (xmo)

For more details, see:
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-878103-fme/+merge/79832

The list view set the dataset.index relative to it's subset of ids according to 
pagination instead of an absolute index on dataset.ids.

Xavier,

Can you check if it's ok to use directly this.dataset instead of this.records ?
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-878103-fme/+merge/79832
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-bug-878103-fme.
=== modified file 'addons/web/static/src/js/view_list.js'
--- addons/web/static/src/js/view_list.js	2011-10-18 10:52:55 +0000
+++ addons/web/static/src/js/view_list.js	2011-10-19 14:58:38 +0000
@@ -780,8 +780,7 @@
                 e.stopPropagation();
                 var row_id = self.row_id(e.currentTarget);
                 if (row_id !== undefined) {
-                    self.dataset.index = self.records.indexOf(
-                        self.records.get(row_id));
+                    self.dataset.index = self.dataset.ids.indexOf(row_id);
                     self.row_clicked(e);
                 }
             });
@@ -789,7 +788,7 @@
     row_clicked: function () {
         $(this).trigger(
             'row_link',
-            [this.records.at(this.dataset.index).get('id'),
+            [this.dataset.ids[this.dataset.index],
              this.dataset]);
     },
     render_cell: function (record, column) {

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to