Review: Disapprove
This change makes precious little sense, and seems to try to make this issue
invisible rather than try to find out what the problem is at its *root* and fix
it:
* It loses the actual context instead of providing for the context's
evaluation, the context in question is `{'default_use_exist':
picking_id.type=='in'}` and you just throw it out and replace it with an
irrelevant pre-evaluated map. Sure there's no more issue, but it absolutely
doesn't do what was asked.
* *Even* if this fix provided for the context's evaluation (by building some
sort of compound context and setting an eval_context on it, or something) it
still would not work: at this point, `picking_id` is an m2o read value meaning
an Array of [Number, String]. Not a `type` attribute in sight
* In fact, if you check how the GTK client behaves (the GTK client is not the
word of god, but it's still interesting to see what it does in various
situations), it logs the following:
Traceback (most recent call last):
File "client/current/bin/tools/__init__.py", line 52, in expr_eval
temp = eval(string, context)
File "<string>", line 1, in <module>
AttributeError: 'int' object has no attribute 'type'
ERROR:tools.expr_eval:{'default_use_exist': picking_id.type=='in'}
blows up right there trying to evaluate the right context with the "right"
values, because the context — as far as I can see — makes no sense
Just because the error appears in the web client doesn't necessarily mean the
error *is* in the web client. In this precise case, it does look like the error
is in the view (in the addons) because they provide a nonsensical context (and
the problem can't be seen in the GTK client because it just ignores it and
hides it under the carpet), but this definitely requires further investigations.
At any rate, this merge proposal is not valid and I'm rejecting it.
--
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-bug-878142-vda/+merge/80024
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openerp-web/trunk-bug-878142-vda.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
