Review: Needs Fixing

Hello vidhin,

Manipulating dom elements in the dialog should not be done directly with jquery 
object but using the this.$element of the dialog. So basically, all jquery 
usage done this way :

if(($(ls).find('a').text()).search("view_id") != -1 && 
parseInt(ls.attr('level')) < level){ ...

should be done this way instead :

if((self.edit_xml_dialog.$element.find(ls).find('a').text()).search("view_id") 
!= -1 && parseInt(ls.attr('level')) < level){

This avoids matching unwanted elements. (eg: two webclients on the same page)

If Move field up or down then I found error :- Uncaught TypeError: Object 
#<XMLSerializer> has no method 'serializeToStream'

Thanks,
-- 
https://code.launchpad.net/~openerp-dev/openerp-web/trunk-vieweditor-save-move-functionality-vme/+merge/80323
Your team OpenERP R&D Team is subscribed to branch 
lp:~openerp-dev/openerp-web/trunk-vieweditor-sma.

_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help   : https://help.launchpad.net/ListHelp

Reply via email to