Review: Needs Fixing
I don't know how you got a traceback, i wasn't able to have any. Can you
provide me a detailed use case on how to get the bug?
I already made a first review, based only on the diff. My comments follow the
line number inside the diff:
* lines 16-22: hu? why do you change something there? what's the reason? i
don't understand what you try to do but this is certainly not good as you put a
return statement inside the loop... it means your code will consider only the
first item of args! If there is no good reason on changing that, please just
revert your code, otherwise explain me.
* lines 35-41: bad copy/past. First, the variable name 'st_line' is stupid.
Secondly, you should use a list comprehension instead:
menu_ids = [report.menu_id.id for report in self.browse(cr, uid, ids,
context) if report.menu_id]
* line 83: copy the context and do your update on the copy rather than on the
original one
--
https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-807961-dbr/+merge/68664
Your team OpenERP R&D Team is subscribed to branch
lp:~openerp-dev/openobject-addons/trunk-bug-807961-dbr.
_______________________________________________
Mailing list: https://launchpad.net/~openerp-dev-gtk
Post to : [email protected]
Unsubscribe : https://launchpad.net/~openerp-dev-gtk
More help : https://help.launchpad.net/ListHelp
