Review: Needs Fixing Hi Purnendu Singh,
2 things: First, do you realize that you made a diff of 874 lines (+389/-386) just for such a silly bug? If you want to redo the indentation that's a good idea but that must be done apart of another merge proposal or it will pollute the patch. Please take my place 2 seconds: how do i know which lines are really changed and which are only reindented? i must go through all the lines and i don't want to because it is really time consuming. Secondly, as we've waited too much there are conflicts again. That's another side effect of your big diff. Make it smaller, only containing the bugfix and it will happen less often. i'm setting this merge prop in "works in progress", reset it to "needs review" when you fixed above points. thanks Quentin -- https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-812784-psi/+merge/68661 Your team OpenERP R&D Team is subscribed to branch lp:~openerp-dev/openobject-addons/trunk-bug-812784-psi. _______________________________________________ Mailing list: https://launchpad.net/~openerp-dev-gtk Post to : [email protected] Unsubscribe : https://launchpad.net/~openerp-dev-gtk More help : https://help.launchpad.net/ListHelp
